Friday, June 17, 2016

Re: AtomicReference


That was just a suggestion.
Guava is involved in the way that it already provides gwt emulation for java.util.concurrent.* classes, e.g. it has emulation of AtomicBoolean, AtomicInteger and AtomicLong. 
It will be easier to merge your PR to Guava because they have more frequent release cycles than GWT has and since GWT 2.8 is about to hit rc1, there is a chance that your PR might get stalled.
But again, that's just my suggestion.

On Friday, June 17, 2016 at 1:23:59 PM UTC+3, Jaroslav Záruba wrote:
I don't use Guava in this very project.
I am completely clueless about what you are suggesting. What I wish to add to GWT is AtomicReference class (as simple as possible) and one or two *.gwt.xml files. How would Guava be involved in that?

Dne pátek 17. června 2016 11:43:27 UTC+2 Andrei Korzhevskii napsal(a):
If you use Guava in your project, I'd send this PR to Guava since they have much frequent releases than GWT does and they accept PRs quite fast.
They currently have atomic references for primitive values but not AtomicReference.


On Friday, June 17, 2016 at 12:32:49 PM UTC+3, Jens wrote:
I can't speak for an official maintainer but I would be fine with it to increase code compatibility. Also the emulation code is pretty straight forward. Its likely that GWT will contain a bit more java.util.concurrent.* emulation in the future as long as it makes sense (e.g. CompletableFuture + what Guava currently provides)

But you can not do Github pull requests. You must sign a CLA and then push your patch to Gerrit, GWT's code review tool.


-- J.

--
You received this message because you are subscribed to the Google Groups "GWT Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscribe@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at https://groups.google.com/group/google-web-toolkit.
For more options, visit https://groups.google.com/d/optout.

No comments:

Post a Comment