Tuesday, May 31, 2011

Re: GWT 2.3 composite editor // setValue called twice

Hi Patrick,

that's true, but it was an example only. You surely should do what you
said but it's still unnecessary (and potentially harmful for the
performance) to do this call twice (by the framework!), so I think
it's a bug in GWT's editor code that should be fixed there and not be
worked around by (application) developers.

Sebastian


On Tue, May 31, 2011 at 3:30 AM, Patrick Tucker <tuckerpmt@gmail.com> wrote:
> I didn't look at the code, so this may not be feasible, but shouldn't
> you be doing this heavy stuff only when the value changes?  It's
> pretty easy to check the current vale prior to doing any work, or
> implement via handling valuechangeevents.
>
> On May 27, 8:27 am, Sebastian Beigel <sebast...@beigel.de> wrote:
>> Hi,
>>
>> unfortunately there seems to be no love for the issue I reported a
>> while ago concerning the revamped editor code (starting w/ GWT 2.3)
>> using Refresher & Initializer.
>>
>> http://code.google.com/p/google-web-toolkit/issues/detail?id=6336
>>
>> Sub-editors' setValue() methods get called twice, which can be a very
>> bad thing if you do something fancy/heavy in you setValue() method.
>> But even for non-visible use-cases (like my trivial example w/
>> TextBoxes) it's unnecessary and a can harm performance.
>>
>> Sebastian
>
> --
> You received this message because you are subscribed to the Google Groups "Google Web Toolkit" group.
> To post to this group, send email to google-web-toolkit@googlegroups.com.
> To unsubscribe from this group, send email to google-web-toolkit+unsubscribe@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
>
>

--
You received this message because you are subscribed to the Google Groups "Google Web Toolkit" group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to google-web-toolkit+unsubscribe@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.

No comments:

Post a Comment