Friday, February 19, 2016

Re: com.google.web.bindery.requestfactory.shared.impl.Constants missing in both requestfactory-client and requestfactory-server



On Thursday, February 18, 2016 at 8:59:10 PM UTC+1, Dirk Holzenburg wrote:
Hi everyone,

why is com.google.web.bindery.requestfactory.shared.impl.Constants missing in both requestfactory-client.jar and requestfactory-server.jar? Is there any particular reason?

Those JARs are extracted from gwt-user.jar using bytecode analysis starting from a few key classes. Because constants are inlined by JavaC, I think the bytecode analysis never ever walks into the Constants class, so it doesn't include it in the JAR.
If you're curious you can see the tool's code here https://gwt.googlesource.com/gwt/+/2.8.0-beta1/user/src/com/google/web/bindery/requestfactory/server/RequestFactoryJarExtractor.java
 
And why is com.google.gwt.thirdparty.json.* missing in the source jars? Legal reasons?

No, com.google.gwt.thirdparty.json is extracted from the Android SDK so is under Apache 2.0. You can find there here https://github.com/gwtproject/tools/tree/master/lib/json/android-sdk-19.1
Again, it's mainly a packaging artefact: the sources aren't included in the RequestFactoryJarExtractor classpath so they're not seen by the tool and cannot be included in the JARs. That being said, even if they were, they have not been "rebased" (from org.json to com.google.gwt.thirdparty.json) so they wouldn't be found either.

--
You received this message because you are subscribed to the Google Groups "GWT Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscribe@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at https://groups.google.com/group/google-web-toolkit.
For more options, visit https://groups.google.com/d/optout.

No comments:

Post a Comment