Re: Contributing: eclipse README outdated?

On Wednesday, October 11, 2017 at 11:13:45 AM UTC+2, Freddy Boucher wrote:

I'm working on https://gwt-review.googlesource.com/c/gwt/+/14430

I rebased the original commit and makes some changes. 

But now when I want to push, I get "you have no 'forge author' permission"

remote: ERROR:  In commit c6a95320212d24d053cb0016b8d82d30f3238b1b

remote: ERROR:  author email address stefan.wiese22@gmail.com

remote: ERROR:  does not match your user account and you have no 'forge author' permission.

remote: ERROR:

remote: ERROR:  The following addresses are currently registered:

remote: ERROR:    freddy.boucher@gmail.com

remote: ERROR:

remote: ERROR:  To register an email address, please visit:

remote: ERROR:  https://gwt-review.googlesource.com/#/settings/contact

Should I push my change as a totally new fix (and amend the author to get rid of the original author)?

I think you have no other choice than to use your own email address as the author (you could use "Stefan Weiss + Freddy Boucher" as the author "name" though; note that the committer will likely be rewritten eventually, so that's also the only way to get credits for your work).

But please keep the same Change-Id.

(and it looks like you pushed a new review, with a new Change-Id, while I was writing this; maybe you could re-push with the old Change-Id, to update the original review, and then abandon the one you just created?)

--
You received this message because you are subscribed to the Google Groups "GWT Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscribe@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at https://groups.google.com/group/google-web-toolkit.
For more options, visit https://groups.google.com/d/optout.