Hi Jens,
Sorry for bothering you again but I am new to this.
I just got my first positive review and I noticed the 'Add Reviewer/ Add CC' buttons and I am wondering if I should manually enter the names you suggested previously in the thread?
Thanks
On Fri, Jan 10, 2020 at 4:21 PM Vassilis Virvilis <vasvir2@gmail.com> wrote:
I actually added a pull/review request on gerrit at 3 Dec 2019but no signs of life so far. It certainly takes a lot of time to review...VassilisOn Mon, Dec 2, 2019 at 1:38 PM Vassilis Virvilis <vasvir2@gmail.com> wrote:Unfortunately GWT does not accept pull request on GitHub.On Thu, Nov 28, 2019 at 3:12 PM Vassilis Virvilis <vasvir2@gmail.com> wrote:ok then.Here is the submitted issue https://github.com/gwtproject/gwt/issues/9675I will try to come with a patch in the next few days.ThanksVassilisOn Thu, Nov 28, 2019 at 9:38 AM Jens <jens.nehlmeier@gmail.com> wrote:--Do you think a patch like that has any chance to be accepted? or this is not considered to be an issue?Seems like a valid behavior for JS libraries to check argument count, so I guess it should be accepted. Goktug or Roberto should probably review it.-- J.
You received this message because you are subscribed to the Google Groups "GWT Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit/9232cdec-c84f-427a-a019-d0cef9262244%40googlegroups.com.
--Vassilis Virvilis
--Vassilis Virvilis
--Vassilis Virvilis
--
Vassilis Virvilis
You received this message because you are subscribed to the Google Groups "GWT Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit/CAKbOjEy5e1ETbVWL6L8Rts73BJbZaSAh5S1jU-QM8cKNT_AjHw%40mail.gmail.com.
No comments:
Post a Comment