On Thursday, February 27, 2014 6:20:27 PM UTC+1, Davide Cavestro wrote:
I've patched the original file in order to provide
- better exit status handling
- alternative output type (a textual representation of the deps tree)
- possibility to write on the standard output
Follows an excerpt from the dependency tree--+com.google.gwt.user.UserAgent |`--+com.google.gwt.useragent.UserAgent |+--+com.google.gwt.core.CoreWithUserAgent | || +--+com.google.gwt.core.EmulateJsStack | || `-->com.google.gwt.core.CompilerParameters |`--+com.google.gwt.emul.EmulationWithUserAgent |`--+com.google.gwt.emul.Emulation |`-->com.google.gwt.logging.LogImpl It works quite fine for me (integrated it into a gradle script) and I'd like to propose a patch, but I've never used gerrit, so I don't know how to propose a new patch to the existing review. May I post the changed file here?
Feel free to post it as a GitHub Gist (or wherever you like), but you could also quite easily update the review in Gerrit.
First create an account in Gerrit, sign the CLA, clone the repo, and setup the commit hook: https://gerrit-review.googlesource.com/Documentation/intro-quick.html
Then you could checkout my review (you'll find the git command in the "download" menu in the upper right in Gerrit), amend the commit (make sure you keep the Change-Id line in the commit message) and then "git push origin HEAD:refs/for/master". The review will be matched by the Change-Id.
Feel free to ask if you need some help setting everything up.
You received this message because you are subscribed to the Google Groups "Google Web Toolkit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscribe@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit.
For more options, visit https://groups.google.com/groups/opt_out.
No comments:
Post a Comment