Re: Issue with enhanced switch statements in GWT 2.12.1

Thanks, this was filed at https://github.com/gwtproject/gwt/issues/10044. The issue is that we misunderstood how the JDT AST handled this case (assumed it was a block ending in a break, rather than a yield with a void expression, which isn't legal in Java), and the tests didn't check for flow in the method after the switch was finished (it is a little awkward to put an assert after a code block and validate not just that it passes but was run at all. We'll get this fixed soon, with better tests as well.

On Thursday, November 21, 2024 at 4:17:32 AM UTC-6 vas...@gmail.com wrote:

lack of caffeine indeed.

Somehow the sentence that was explaining the problem disappeared for me between scrolls..

Sorry

On Thu, Nov 21, 2024 at 10:38 AM Vassilis Virvilis <vas...@gmail.com> wrote:

I must be low on caffeine because I can't see the problem.

Is the problem that it doesn't print:

Test 2 - Done

at the end?

On Thu, Nov 21, 2024 at 10:28 AM Craig Mitchell <ma...@craig-mitchell.com> wrote:

The release notes for 2.12.1 ( https://www.gwtproject.org/release-notes.html#Release_Notes_2_12_1 ) say:

> Switch statements can correctly compile without being contained in braces

For me, they compile, but they don't work.  Eg.  This code:

GWT.log("Test 1 - Start");
switch (1) {
  case 1 -> {
    GWT.log("Test 1 - 1");
  }
  case 2 -> {
    GWT.log("Test 1 - 2");
  }
  case 3 -> {
    GWT.log("Test 1 - 3");
  }
}
GWT.log("Test 1 - Done");

GWT.log("Test 2 - Start");
switch (1) {
  case 1 -> GWT.log("Test 2 - 1");
  case 2 -> GWT.log("Test 2 - 2");
  case 3 -> GWT.log("Test 2 - 3");
}
GWT.log("Test 2 - Done");

Will never get to the last "Test 2 - Done" line.  The output will be:

Test 1 - Start
Test 1 - 1
Test 1 - Done
Test 2 - Start
Test 2 - 1

Is this a known issue?

Thanks.

--
You received this message because you are subscribed to the Google Groups "GWT Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-web-tool...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/google-web-toolkit/d0b4fe79-0571-481a-bf4f-c8ccda40e486n%40googlegroups.com.

--

Vassilis Virvilis

--

Vassilis Virvilis

--
You received this message because you are subscribed to the Google Groups "GWT Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/google-web-toolkit/51661537-7faf-4e9f-a6e5-41e331f17e8fn%40googlegroups.com.