Friday, July 20, 2018

Re: All current JsInterop-Annotations jar files are missing manifest content.



On Friday, July 20, 2018 at 1:49:44 PM UTC+2, Rasmus Olesen wrote:
Hi

Is there a specific reason for the jsinterop-annotations jar files not containing any manifest files/info/content ?

This is just a side-effect of how they're produced: https://gwt.googlesource.com/gwt/+/2.8.2/maven/lib-gwt.sh#93
 
It might not be needed for the included annotations, but we really need it for handling jar files during build and deployment.
And isn't it bad practice to release jar files without a manifest?

Bad practice? No idea. Not that I know.
In all honesty, I've never ever used JAR manifests, except in a few cases with a Main-Class.

Feel free (and invited!) to contribute a patch to the scripts to ensure a manifest is present in all JARs.

--
You received this message because you are subscribed to the Google Groups "GWT Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscribe@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at https://groups.google.com/group/google-web-toolkit.
For more options, visit https://groups.google.com/d/optout.

No comments:

Post a Comment